-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BeamSpot Object and Records #29662
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15062
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29662/15138
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages: CondCore/BeamSpotPlugins @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
ERROR: empty variable. PR had errors - #29662. |
-1 Tested at: e2982ad CMSSW: CMSSW_11_1_X_2020-05-18-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
Comparison job queued. |
From the error logs I see a |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
PR description:
This PR introduces one new BeamSpot object and three new BeamSpot records that will be used to pass the BeamSpot information to the HLT on a lumi-by-lumi basis.
Newly introduced objets:
BeamSpotOnlineObjects
inherits from the already existingBeamSpotObjects
and contains few new members (last analyzed lumi, run and fill)BeamSpotOnlineHLTObjectsRcd
andBeamSpotOnlineLegacyObjectsRcd
are two new records based on theBeamSpotOnlineObjects
that will hold the information from the two running BeamSpot DQM clientsBeamSpotTransientObjectsRcd
is a dependent record that depends onBeamSpotOnlineHLTObjectsRcd
andBeamSpotOnlineLegacyObjectsRcd
and holds the final beamspot that will be passed to HLTCondTools/BeamSpot
Coming next
This PR will be followed by two other PRs:
DQM/BeamMonitor
andDQM/Integration
)